Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to delete by using labels. Depended on by #2116 #2123

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 31, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Depended on by #2116

This PR is primarily aimed at migrating argo delete to using the apiclient. I present it as a good example of this because:

  • I did quite a bit of refactoring of delete.go and it behaves slightly different.
  • I added support for --selector as I thought we should not want out tests to delete workflows not labelled with `argo-e2e'. This is a new feature.
  • I wrote 4 new e2e tests.
  • I actually delete more production code than I wrote.

@whynowy @simster7 @sarabala1979

test/e2e/fixtures/when.go Outdated Show resolved Hide resolved
test/e2e/cli_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2123   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          52       52           
  Lines       26353    26353           
=======================================
  Hits         3081     3081           
  Misses      22877    22877           
  Partials      395      395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cd72b...96bb8d1. Read the comment docs.

@alexec alexec marked this pull request as ready for review January 31, 2020 20:59
@alexec
Copy link
Contributor Author

alexec commented Jan 31, 2020

@sarabala1979 could I please ask you to review this and other "workflow CLI" PRs?

@alexec alexec merged commit badfd18 into argoproj:master Feb 1, 2020
@alexec alexec deleted the cli-delete branch February 1, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants