Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add CronWorkflow usage docs #2124

Merged
merged 2 commits into from
Feb 1, 2020
Merged

docs: Add CronWorkflow usage docs #2124

merged 2 commits into from
Feb 1, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Jan 31, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

simster7
simster7 commented Jan 31, 2020
View reviewed changes
docs/cron-workflows.md
### GitOps via Argo CD

`CronWorkflow` resources can be managed with GitOps by using [Argo CD](https://github.com/argoproj/argo-cd)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shout out 🐙

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems tangential to the docs, do we really need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a bit tangential, but I only recently realized this could be done thought it would be useful to have it documented. Can totally remove if necessary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about this. Leave it if you like. Docs are living things.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it then

alexec
alexec reviewed Jan 31, 2020
View reviewed changes
docs/cron-workflows.md Outdated Show resolved Hide resolved
docs/cron-workflows.md
### GitOps via Argo CD

`CronWorkflow` resources can be managed with GitOps by using [Argo CD](https://github.com/argoproj/argo-cd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems tangential to the docs, do we really need it?

docs/cron-workflows.md Show resolved Hide resolved
@simster7
Copy link
Member Author

simster7 commented Feb 1, 2020

Feel free to approve/merge this whenever

@alexec alexec merged commit 7881b98 into master Feb 1, 2020
@alexec alexec deleted the cron-wf-docs branch February 1, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simster7 @alexec