test: Try and make e2e more robust. Fixes #2125 #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Jan 31, 2020
alexec
commented
Jan 31, 2020
| @@ -71,8 +71,6 @@ func (s *E2ESuite) BeforeTest(_, _ string) { | |||
| s.Diagnostics = &Diagnostics{} | |||
|
|
|||
| s.DeleteResources(Label) | |||
| // create database collection | |||
| s.Persistence.DeleteEverything() | |||
There was a problem hiding this comment.
I've removed this because it was often deleting offloaded data in non-e2e test. Now we delete specifically the e2e workflows.
|
@simster7 do you think you could be the reviewer for this please? |
|
Oh - if this passes CI - just merge it! |
Codecov Report
@@ Coverage Diff @@
## master #2127 +/- ##
=======================================
Coverage 11.69% 11.69%
=======================================
Files 52 52
Lines 26353 26353
=======================================
Hits 3081 3081
Misses 22877 22877
Partials 395 395Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes #2125