Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed ui navigation issues with basehref. Fixes #2113 #2130

Merged
merged 1 commit into from
Feb 1, 2020
Merged

fix(ui): fixed ui navigation issues with basehref. Fixes #2113 #2130

merged 1 commit into from
Feb 1, 2020

Conversation

fsiegmund
Copy link
Contributor

@fsiegmund fsiegmund commented Feb 1, 2020

Added missing uiUrl calls and fixed browser history initialization.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2113

@claassistantio
Copy link

claassistantio commented Feb 1, 2020

CLA assistant check
All committers have signed the CLA.

@fsiegmund fsiegmund requested a review from alexec February 1, 2020 01:18
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this changes.

@alexec alexec added this to the v2.5 milestone Feb 1, 2020
@alexec
Copy link
Contributor

alexec commented Feb 1, 2020

The failure of the "e2e-postgres" is not related the changes in this PR. It is flakiness that has been fixed on master around 4:15pm (PST) today. I'll re-run your workflows and it may pass on a second attempt. If not, git merge master will sort it out.

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #2130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2130   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          52       52           
  Lines       26353    26353           
=======================================
  Hits         3081     3081           
  Misses      22877    22877           
  Partials      395      395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75ac1b...f9c54a6. Read the comment docs.

@alexec alexec merged commit 91319ee into argoproj:master Feb 1, 2020
@fsiegmund fsiegmund deleted the fsiegmund-ui-navigation-fixes branch February 1, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation errors in new UI
3 participants