fix: archiveLogs needs to copy stderr #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
=======================================
Coverage 11.69% 11.69%
=======================================
Files 52 52
Lines 26353 26353
=======================================
Hits 3081 3081
Misses 22877 22877
Partials 395 395Continue to review full report at Codecov.
|
This was referenced Feb 3, 2020
|
Thank you for this fix. |
alexec
approved these changes
Feb 3, 2020
4 tasks
alexec
reviewed
Feb 19, 2020
| if err != nil { | ||
| return nil, errors.InternalWrapError(err) | ||
| } | ||
| reader = ioutil.NopCloser(io.MultiReader(reader, stderr)) |
There was a problem hiding this comment.
maybe we do not close this correctly
There was a problem hiding this comment.
I'm not sure it needs to though. We aren't going to leak file handles as the executor actually exits after this. I've not seen any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.