Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs UI should fall back to archive. Fixes #2137 #2139

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

tcolgate
Copy link
Contributor

@tcolgate tcolgate commented Feb 3, 2020

I've not tested this yet, and I don't /really/ know what I'm doing. But
the onerror handler currently breaks the logs UI as it does not result
in the catch getting triggered.

Fixes #2137

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #2139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2139   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          52       52           
  Lines       26353    26353           
=======================================
  Hits         3081     3081           
  Misses      22877    22877           
  Partials      395      395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91319ee...c9c9e0e. Read the comment docs.

@alexec alexec self-assigned this Feb 3, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a go!

@alexec alexec marked this pull request as ready for review February 3, 2020 19:50
@alexec alexec merged commit 059cb9b into argoproj:master Feb 3, 2020
@alexec alexec changed the title fix: logs UI should fall back to archive fix: logs UI should fall back to archive. Fixes #2137 Feb 3, 2020
@alexec alexec mentioned this pull request Feb 20, 2020
4 tasks
@MrSaints
Copy link

I'm not sure if this is quite fixed. On v2.5.1, I'm getting:

 Waiting for data...

When the underlying pod does not exist anymore.

@alexec
Copy link
Contributor

alexec commented Feb 24, 2020

@MrSaints looks like the fix broke something - you should be able to find your logs in the artifacts tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Logs link does not fall back to archive
3 participants