Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct SQL syntax. #2141

Merged
merged 3 commits into from
Feb 3, 2020
Merged

fix: Correct SQL syntax. #2141

merged 3 commits into from
Feb 3, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 3, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

See #1974

@alexec alexec added this to the v2.5 milestone Feb 3, 2020
@alexec
Copy link
Contributor Author

alexec commented Feb 3, 2020

@sarabala1979 please review?

@codecov
Copy link

codecov bot commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #2141 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2141      +/-   ##
=========================================
+ Coverage   11.69%   11.7%   +0.01%     
=========================================
  Files          52      51       -1     
  Lines       26353   26321      -32     
=========================================
  Hits         3081    3081              
+ Misses      22877   22845      -32     
  Partials      395     395
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0% <0%> (ø) ⬆️
persist/sqldb/workflow_archive.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cda9a0...1a586e0. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 3, 2020 17:46
@alexec alexec mentioned this pull request Feb 3, 2020
Merged
5 tasks
alexec
alexec commented Feb 3, 2020
View reviewed changes
persist/sqldb/workflow_archive.go
@@ -78,7 +78,7 @@ func (r *workflowArchive) ArchiveWorkflow(wf *wfv1.Workflow) error {
Set("startedat", wf.Status.StartedAt.Time).
Set("finishedat", wf.Status.FinishedAt.Time).
Where(db.Cond{"clustername": r.clusterName}).
And(db.Cond{"uuid": wf.UID}).
And(db.Cond{"uid": wf.UID}).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pft

@alexec alexec merged commit 520fa54 into argoproj:master Feb 3, 2020
@alexec alexec deleted the fix-uuid branch February 3, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @sarabala1979