Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify download .tgz extension #2164

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Feb 4, 2020

Fixes: #2163 by adding the Content-Disposition header with the desired file extension.

Thanks @ddseapy for reporting this bug.

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2164 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2164      +/-   ##
=========================================
+ Coverage    11.7%   11.7%   +<.01%     
=========================================
  Files          51      51              
  Lines       26329   26321       -8     
=========================================
  Hits         3081    3081              
+ Misses      22853   22845       -8     
  Partials      395     395
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f591c47...8ffb59d. Read the comment docs.

@alexec alexec added this to the v2.5 milestone Feb 4, 2020
@alexec alexec self-assigned this Feb 4, 2020
@simster7 simster7 merged commit f6cee55 into argoproj:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts download as .gz through UI when they are .tgz
2 participants