Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Retry workflow event stream on connection loss. Fixes #2179 #2180

Merged
merged 3 commits into from
Feb 6, 2020
Merged

fix(ui): Retry workflow event stream on connection loss. Fixes #2179 #2180

merged 3 commits into from
Feb 6, 2020

Conversation

fsiegmund
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@fsiegmund fsiegmund requested a review from alexec February 6, 2020 13:41
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2180 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
+ Coverage   11.69%   11.71%   +0.01%     
==========================================
  Files          52       51       -1     
  Lines       26353    26309      -44     
==========================================
  Hits         3081     3081              
+ Misses      22877    22833      -44     
  Partials      395      395
Impacted Files Coverage Δ
persist/sqldb/workflow_archive.go 0% <0%> (ø) ⬆️
persist/sqldb/migrate.go 0% <0%> (ø) ⬆️
workflow/validate/lint.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ee297...dfb1fab. Read the comment docs.

@alexec alexec merged commit fc476b2 into argoproj:master Feb 6, 2020
@alexec
Copy link
Contributor

alexec commented Feb 6, 2020

good work - thank you

@fsiegmund fsiegmund deleted the retry-workflows branch February 11, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants