Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove quotes from UI #2213

Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix: Remove quotes from UI #2213

merged 1 commit into from
Feb 11, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 11, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@alexec alexec added this to the v2.5 milestone Feb 11, 2020
@alexec alexec requested a review from simster7 February 11, 2020 21:56
@alexec alexec added the type/regression Regression from previous behavior (a specific type of bug) label Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@62f4668). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2213   +/-   ##
========================================
  Coverage          ?   11.7%           
========================================
  Files             ?      52           
  Lines             ?   26322           
  Branches          ?       0           
========================================
  Hits              ?    3081           
  Misses            ?   22846           
  Partials          ?     395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f4668...b3c1799. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 11, 2020 22:12
@alexec alexec merged commit f2bd74b into argoproj:master Feb 11, 2020
@alexec alexec deleted the log-ui branch February 11, 2020 22:12
alexec added a commit that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants