Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI Responsive design on filter box #2221

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

simster7
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #2221 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2221      +/-   ##
=========================================
+ Coverage    11.7%   11.7%   +<.01%     
=========================================
  Files          52      52              
  Lines       26322   26313       -9     
=========================================
  Hits         3081    3081              
+ Misses      22846   22837       -9     
  Partials      395     395
Impacted Files Coverage Δ
workflow/controller/controller.go 0.61% <0%> (ø) ⬆️
persist/sqldb/offload_node_status_repo.go 4.5% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30b77f...4c86a2b. Read the comment docs.

@simster7 simster7 requested review from whynowy and alexec February 12, 2020 17:11
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to cherry-pick to release-2.5 branch pleas?

@simster7 simster7 merged commit af1f6d6 into argoproj:master Feb 12, 2020
@simster7
Copy link
Member Author

@alexec Just noticed taht #2196 is not actually on the release branch, therefore this doesn't have to be cherry-picked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter box has buggy responsive design
2 participants