feat: Reduce API calls when changing filters. Closes #2231 #2232
Conversation
whynowy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
=======================================
Coverage 11.82% 11.82%
=======================================
Files 52 52
Lines 26354 26354
=======================================
Hits 3116 3116
Misses 22837 22837
Partials 401 401Continue to review full report at Codecov.
|
| @@ -6,7 +6,13 @@ import {TagsInput} from '../../../shared/components/tags-input/tags-input'; | |||
|
|
|||
| require('./workflow-filters.scss'); | |||
|
|
|||
| export enum FilterType { | |||
There was a problem hiding this comment.
Archived workflow list page filter will be able to re-use the same component.
| @@ -115,24 +120,32 @@ export class WorkflowsList extends BasePage<RouteComponentProps<any>, State> { | |||
| ); | |||
| } | |||
|
|
|||
| private fetchWorkflows(): void { | |||
| private fetchWorkflows(namespace: string, selectedPhases: string[], selectedLabels: string[]): void { | |||
There was a problem hiding this comment.
Change to use passed in variables because it seems like setState is async and using this.state.xxx right after setState does not return latest value.
| interface WorkflowFilterProps { | ||
| type: FilterType; |
There was a problem hiding this comment.
this creates tight coupling between the components - I think you need to decouple them
ui/src/app/workflows/components/workflows-list/workflows-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/workflows/components/workflows-list/workflows-list.tsx
Outdated
Show resolved
Hide resolved
| .then(info => { | ||
| if (info.managedNamespace && info.managedNamespace !== this.state.namespace) { | ||
| this.setState({namespace: info.managedNamespace}); | ||
| let l; |
There was a problem hiding this comment.
Can we have full variable names?
| if (info.managedNamespace && info.managedNamespace !== this.state.namespace) { | ||
| this.setState({namespace: info.managedNamespace}); | ||
| let l; | ||
| let ns = namespace; |
Closes #2231.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".