Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add filters for archived workflows. Closes #2259 #2257

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Feb 18, 2020

Closes #2259

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

title='Archived Workflows'
toolbar={{
breadcrumbs: [{title: 'Archived Workflows', path: uiUrl('archived-workflows')}],
actionMenu: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a Submit New Workflow button on this page. This workarounds the unclear Page/toolbar bug.

More information about the bug mentioned above - When there's actionMenu or tools in toolbar, or toolbar is removed, the page will get too much recursion error when making several changes on the namespace or label field. A rough investigation shows there might be some conflict between Page/toolbar and Autocomplete.

Add a Submit New WF button here to bypass it for now and look into the issue further later.

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #2257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2257   +/-   ##
=======================================
  Coverage   11.35%   11.35%           
=======================================
  Files          71       71           
  Lines       27979    27979           
=======================================
  Hits         3178     3178           
  Misses      24396    24396           
  Partials      405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d88374...19660a4. Read the comment docs.

@whynowy whynowy requested review from alexec and simster7 and removed request for alexec February 18, 2020 19:00
@whynowy whynowy changed the title feat(ui): Add filters for archived workflows. Closes #2171 feat(ui): Add filters for archived workflows. Closes #2259 Feb 18, 2020
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whynowy whynowy merged commit b5c4726 into argoproj:master Feb 18, 2020
@whynowy whynowy deleted the archfilter branch February 18, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filters to archived workflow list page
2 participants