Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Migrate argo terminate to use API client. See #2116 #2280

Merged
merged 5 commits into from
Feb 24, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 20, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

See #2116

@alexec alexec added this to the Backlog milestone Feb 20, 2020
@alexec alexec linked an issue Feb 20, 2020 that may be closed by this pull request
15 tasks
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@36d6178). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2280   +/-   ##
=========================================
  Coverage          ?   11.39%           
=========================================
  Files             ?       71           
  Lines             ?    27903           
  Branches          ?        0           
=========================================
  Hits              ?     3180           
  Misses            ?    24319           
  Partials          ?      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d6178...ada4917. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 21, 2020 00:44
@alexec alexec requested a review from simster7 February 21, 2020 00:44
@alexec alexec merged commit 636ea44 into argoproj:master Feb 24, 2020
@alexec alexec deleted the cli-term branch February 24, 2020 19:41
alexec added a commit to alexec/argo-workflows that referenced this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CLI workflow commands to use apiclient.Client
2 participants