Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Reinstate argo wait. Fixes #2281 #2283

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 20, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2281
This can be merged as soon as approved and needs to be back-ported to v2.5

@alexec alexec added this to the v2.5 milestone Feb 20, 2020
@alexec alexec requested a review from sarabala1979 February 20, 2020 22:51
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #2283 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2283   +/-   ##
=======================================
  Coverage   11.38%   11.39%           
=======================================
  Files          71       71           
  Lines       27933    27914   -19     
=======================================
  Hits         3180     3180           
+ Misses      24349    24330   -19     
  Partials      404      404           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3d2f5...09153f5. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 20, 2020 23:10
@sarabala1979 sarabala1979 merged commit 47b4fc2 into argoproj:master Feb 21, 2020
@alexec alexec deleted the add-wait branch February 21, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo wait removed from v2.5.0
2 participants