Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): 2x simplify migration to API client. See #2116 #2290

Merged
merged 6 commits into from
Feb 22, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 21, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

See #2116
I found myself copy-and-pasting lots of code from the CLI to server in other PRs. I kept thinking "I have 2 copies of the code", this PR reduces it to one copy.

@alexec alexec added this to the Backlog milestone Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #2290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   11.41%   11.41%           
=======================================
  Files          71       71           
  Lines       27899    27899           
=======================================
  Hits         3185     3185           
  Misses      24310    24310           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad42e39...26ee34e. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 21, 2020 19:51
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/argo-server/swagger.json Outdated Show resolved Hide resolved
@alexec alexec merged commit 0d3955a into argoproj:master Feb 22, 2020
@alexec alexec deleted the kube-client branch February 22, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants