build: Improve reliability of release. #2309
Conversation
| # Push images to Docker Hub | ||
| docker push $(IMAGE_NAMESPACE)/argocli:$(VERSION) | ||
| docker push $(IMAGE_NAMESPACE)/argoexec:$(VERSION) | ||
| docker push $(IMAGE_NAMESPACE)/workflow-controller:$(VERSION) | ||
| git push --follow-tags |
There was a problem hiding this comment.
follow tags never seemed to work correctly
| @@ -429,21 +430,23 @@ api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger $(SWAGGER_FILES) dist/MANI | |||
| # pre-push | |||
|
|
|||
| .PHONY: pre-commit | |||
| pre-commit: test codegen manifests lint start pf-bg smoke test-api test-cli | |||
| pre-commit: test lint codegen manifests start pf-bg smoke test-api test-cli | |||
There was a problem hiding this comment.
this re-ordering will reduce the number of go.mod/sum changes we get
|
|
||
| # release | ||
| # release - targets only available on release branch | ||
| ifneq ($(findstring release,$(GIT_BRANCH)),) |
There was a problem hiding this comment.
this change actually remove targets if you should not be able to do them
| @@ -429,21 +430,23 @@ api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger $(SWAGGER_FILES) dist/MANI | |||
| # pre-push | |||
|
|
|||
| .PHONY: pre-commit | |||
| pre-commit: test codegen manifests lint start pf-bg smoke test-api test-cli | |||
| pre-commit: test lint codegen manifests start pf-bg smoke test-api test-cli | |||
There was a problem hiding this comment.
this re-ordering will reduce the number of go.mod/sum changes we get
| @@ -429,21 +430,23 @@ api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger $(SWAGGER_FILES) dist/MANI | |||
| # pre-push | |||
|
|
|||
| .PHONY: pre-commit | |||
| pre-commit: test codegen manifests lint start pf-bg smoke test-api test-cli | |||
| pre-commit: test lint codegen manifests start pf-bg smoke test-api test-cli | |||
There was a problem hiding this comment.
this re-ordering will reduce the number of go.mod/sum changes we get
Codecov Report
@@ Coverage Diff @@
## master #2309 +/- ##
=========================================
Coverage ? 13.01%
=========================================
Files ? 70
Lines ? 24492
Branches ? 0
=========================================
Hits ? 3188
Misses ? 20899
Partials ? 405Continue to review full report at Codecov.
|
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have already merge this to release-2.5 and release-2.6. It does fully automate releases yet, but makes the process simpler and more reliable by making sure you are clean, dist is created, and you build before you publish.
Please merge as soon as approved and builds are green.