Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update getting-started guide for 2.5.2 and apply other tweaks #2311

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

crenshaw-dev
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

The namespace changes feel strange to me... is there a reason why getting-started namespaces to argo by default? If not, I'd as soon drop -n argo from all the below commands and just add a link pointing to the namespaced install yaml.

@claassistantio
Copy link

claassistantio commented Feb 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e49dd8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2311   +/-   ##
=========================================
  Coverage          ?   13.21%           
=========================================
  Files             ?       70           
  Lines             ?    24166           
  Branches          ?        0           
=========================================
  Hits              ?     3194           
  Misses            ?    20567           
  Partials          ?      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49dd8c...e2947af. Read the comment docs.

docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
Copy link
Member Author

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simster7 changes made and issue submitted for the odd behavior that led me to think workflows had to be in the same namespace as the controller.

docs/getting-started.md Show resolved Hide resolved
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mac9416!

@simster7 simster7 merged commit 8da88d7 into argoproj:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants