-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update getting-started guide for 2.5.2 and apply other tweaks #2311
Conversation
3b8b74f
to
43b804a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
=========================================
Coverage ? 13.21%
=========================================
Files ? 70
Lines ? 24166
Branches ? 0
=========================================
Hits ? 3194
Misses ? 20567
Partials ? 405 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mac9416!
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.The namespace changes feel strange to me... is there a reason why getting-started namespaces to
argo
by default? If not, I'd as soon drop-n argo
from all the below commands and just add a link pointing to the namespaced install yaml.