Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to include or exclude fields in the response. Closes #2294 #2326

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Feb 27, 2020

Closes: #2294

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@whynowy whynowy changed the title feat: Ability to include or exclude fields in the response feat: Ability to include or exclude fields in the response. Closes #2294 Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@efb8a1a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2326   +/-   ##
=========================================
  Coverage          ?   13.38%           
=========================================
  Files             ?       70           
  Lines             ?    24232           
  Branches          ?        0           
=========================================
  Hits              ?     3244           
  Misses            ?    20579           
  Partials          ?      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb8a1a...5815996. Read the comment docs.

@sarabala1979 sarabala1979 self-assigned this Feb 27, 2020
}

var (
StreamForwarder = func(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im assuming this was a duplicate file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexec - what do you mean? this is a deleted file

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval. I’m assuming this code is all the same as Argo CD. Good work on the quick turn around and tests.

@whynowy
Copy link
Member Author

whynowy commented Feb 28, 2020

Conditional approval. I’m assuming this code is all the same as Argo CD. Good work on the quick turn around and tests.

@alexec - I moved the code from argo-cd to pkg, and we are referencing pkg.

@whynowy whynowy merged commit 62e6db8 into argoproj:master Feb 28, 2020
@whynowy whynowy deleted the output-selector branch February 28, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow status API
3 participants