-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to include or exclude fields in the response. Closes #2294 #2326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2326 +/- ##
=========================================
Coverage ? 13.38%
=========================================
Files ? 70
Lines ? 24232
Branches ? 0
=========================================
Hits ? 3244
Misses ? 20579
Partials ? 409 Continue to review full report at Codecov.
|
} | ||
|
||
var ( | ||
StreamForwarder = func( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im assuming this was a duplicate file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexec - what do you mean? this is a deleted file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval. I’m assuming this code is all the same as Argo CD. Good work on the quick turn around and tests.
@alexec - I moved the code from argo-cd to |
Closes: #2294
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.