Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dockerfile): Using --no-install-recommends (Optimization) #2329

Merged
merged 14 commits into from
Mar 2, 2020
Merged

fix(Dockerfile): Using --no-install-recommends (Optimization) #2329

merged 14 commits into from
Mar 2, 2020

Conversation

Rajpratik71
Copy link
Contributor

Using a --no-install-recommends when apt-get installing packages.

This will result in a smaller image size.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@Rajpratik71
Using --no-install-recommends (Optimization)
fc11b66 
Using `--no-install-recommends` (Optimization)

Using a --no-install-recommends when apt-get installing packages.

This will result in a smaller image size.
@Rajpratik71
Using --no-install-recommends (Optimization)
68002a6 
Using `--no-install-recommends` (Optimization)

Using a --no-install-recommends when apt-get installing packages.

This will result in a smaller image size.
@alexec
Copy link
Contributor

alexec commented Feb 28, 2020

What is not installed by this change please? How much smaller is the image?

@Rajpratik71
added some more cleanup tweaks
36597d9 
More cleanup tweaks using 

1. apt-get clean 

2. rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

removing downloaded packages and packages list will free up some space ,

results in smaller image size.
@codecov
Copy link

codecov bot commented Feb 29, 2020 •
edited
Loading

Codecov Report

Merging #2329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2329   +/-   ##
=======================================
  Coverage   13.38%   13.38%           
=======================================
  Files          70       70           
  Lines       24232    24232           
=======================================
  Hits         3244     3244           
  Misses      20579    20579           
  Partials      409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb8a1a...bdcea40. Read the comment docs.

@Rajpratik71
added some more cleanup tweaks
2a5d3e6 
More cleanup tweaks using 

1. apt-get clean 

2. rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

removing downloaded packages and packages list will free up some space ,

results in smaller image size.
@Rajpratik71
added some more cleanup tweaks
65b41c4 
More cleanup tweaks using 

1. apt-get clean 

2. rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

removing downloaded packages and packages list will free up some space ,

results in smaller image size.
@Rajpratik71
Copy link
Contributor Author

By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages .

By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install.

This results in smaller downloads and installation of packages .

Refer to blog at Ubuntu Blog .

Another Cleanup tweaks using

  1. apt-get clean

  2. rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

removing downloaded packages and packages list will free up some space ,

results in smaller image size.

@Rajpratik71
Update Dockerfile
3dc1db3
@Rajpratik71
Update Dockerfile.dev
6d28345
@Rajpratik71
Update Dockerfile
9010f26
@Rajpratik71
added packages apt-utils and apt-transport-https
a01f7b3 
Because Github CI build is 

1.  Slow and in log it is showing because "apt-utils" not installed 

2. CI build exits with error in having certificate
@Rajpratik71
added packages apt-utils and apt-transport-https
77b4a95 
Because Github CI build is 

1.  Slow and in log it is showing because "apt-utils" not installed 

2. CI build exits with error in having certificate
@Rajpratik71
added packages apt-utils and apt-transport-https
9f8ac68 
Because Github CI build is 

1.  Slow and in log it is showing because "apt-utils" not installed 

2. CI build exits with error in having certificate
@Rajpratik71
another fix for CI build error
43d01aa 
The  CI build end with error 

#7 12.12 curl: (77) error setting certificate verify locations:
#7 12.12   CAfile: /etc/ssl/certs/ca-certificates.crt
#7 12.12   CApath: /etc/ssl/certs

The fix for this i found is installing "ca-certificates" package for debian based systems
@Rajpratik71
another fix for CI build error
8b3f05e 
The  CI build end with error 

#7 12.12 curl: (77) error setting certificate verify locations:
#7 12.12   CAfile: /etc/ssl/certs/ca-certificates.crt
#7 12.12   CApath: /etc/ssl/certs

The fix for this i found is installing "ca-certificates" package for debian based systems
@Rajpratik71
another fix for CI build error
bdcea40 
The  CI build end with error 

#7 12.12 curl: (77) error setting certificate verify locations:
#7 12.12   CAfile: /etc/ssl/certs/ca-certificates.crt
#7 12.12   CApath: /etc/ssl/certs

The fix for this i found is installing "ca-certificates" package for debian based systems
@alexec alexec merged commit 8672b97 into argoproj:master Mar 2, 2020
@alexec
Copy link
Contributor

alexec commented Mar 2, 2020

Great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rajpratik71 @alexec