Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Compact graph by using circles rather than panels #2349

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 3, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Question: should the default be horizontal (time is commonly represented on the horizontal axis) or vertical (as it is today)?

Screen Shot 2020-02-28 at 3 24 16 PM
Screen Shot 2020-03-03 at 10 37 45 AM
Screen Shot 2020-02-28 at 3 24 07 PM

@alexec alexec requested review from alexmt and simster7 March 3, 2020 18:41
@simster7
Copy link
Member

simster7 commented Mar 3, 2020

Question: should the default be horizontal (time is commonly represented on the horizontal axis) or vertical (as it is today)?

Vertical should be default, with option to switch in my opinion.

This looks great btw

@alexec alexec requested a review from sarabala1979 March 3, 2020 19:25
@alexec alexec marked this pull request as ready for review March 4, 2020 02:08
@alexec alexec merged commit 7e2dba0 into argoproj:master Mar 4, 2020
@alexec alexec deleted the circles branch March 4, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants