Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't display Retry Nodes in UI if len(children) == 1 #2390

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Mar 8, 2020

Fixes #2384. This new behavior reflects argo watch correctly.

Before:
image
After:
image

Behavior if len(children) > 1 is conserved:
image

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #2390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2390   +/-   ##
=======================================
  Coverage   13.13%   13.13%           
=======================================
  Files          72       72           
  Lines       25084    25084           
=======================================
  Hits         3294     3294           
  Misses      21375    21375           
  Partials      415      415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e11fc...bd6bed7. Read the comment docs.

@simster7 simster7 merged commit d119475 into argoproj:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show retries in UI if first try succeeds
2 participants