Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Use a monospace font family for yaml editors. Closes #2378 #2394

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

changhc
Copy link
Contributor

@changhc changhc commented Mar 9, 2020

Closes #2378.

Also I updated the min-height of the editor. The default 50px was annoying.

Screenshot:
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d119475). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2394   +/-   ##
=========================================
  Coverage          ?   13.13%           
=========================================
  Files             ?       72           
  Lines             ?    25084           
  Branches          ?        0           
=========================================
  Hits              ?     3294           
  Misses            ?    21375           
  Partials          ?      415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d119475...6911719. Read the comment docs.

@alexec alexec added this to the v2.7 milestone Mar 9, 2020
@alexec
Copy link
Contributor

alexec commented Mar 9, 2020

Great UI tweak - thank you!

@alexec alexec merged commit 175b164 into argoproj:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a monospace font family for yaml editors in UI
2 participants