-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly report version. Fixes #2374 #2402
Conversation
Should back-port. |
Codecov Report
@@ Coverage Diff @@
## master #2402 +/- ##
=======================================
Coverage 13.13% 13.13%
=======================================
Files 72 72
Lines 25084 25084
=======================================
Hits 3294 3294
Misses 21375 21375
Partials 415 415 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the code that reports the version already in the code base, but wasn't working due to the fact that the .git
folder wasn't in the image?
Correct. This because we could not determine the Git version when we build in container (i.e DEV_IMAGE=false) as .git was not there. |
LGTM |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.Fixes #2374