Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly report version. Fixes #2374 #2402

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 9, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2374

@alexec alexec added this to the v2.7 milestone Mar 9, 2020
@alexec alexec requested a review from simster7 March 9, 2020 22:51
@alexec alexec requested a review from sarabala1979 March 9, 2020 22:51
@alexec alexec modified the milestones: v2.7, v2.6 Mar 9, 2020
@alexec alexec marked this pull request as ready for review March 9, 2020 22:57
@alexec
Copy link
Contributor Author

alexec commented Mar 9, 2020

Should back-port.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #2402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2402   +/-   ##
=======================================
  Coverage   13.13%   13.13%           
=======================================
  Files          72       72           
  Lines       25084    25084           
=======================================
  Hits         3294     3294           
  Misses      21375    21375           
  Partials      415      415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175b164...d0f13f3. Read the comment docs.

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code that reports the version already in the code base, but wasn't working due to the fact that the .git folder wasn't in the image?

@alexec
Copy link
Contributor Author

alexec commented Mar 10, 2020

Is the code that reports the version already in the code base, but wasn't working due to the fact that the .git folder wasn't in the image?

Correct. This because we could not determine the Git version when we build in container (i.e DEV_IMAGE=false) as .git was not there.

@simster7
Copy link
Member

LGTM

@alexec alexec merged commit 068a433 into argoproj:master Mar 10, 2020
@alexec alexec deleted the git-ver branch March 10, 2020 19:38
alexec added a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log version on start-up
2 participants