-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): cache namespace selection. Closes #2439 #2441
Conversation
ui/src/app/shared/utils.ts
Outdated
@@ -120,5 +120,13 @@ export const Utils = { | |||
return false; | |||
} | |||
return wf.status.phase === 'Running'; | |||
}, | |||
|
|||
setCachedNamespace(value: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor - could this be a getter/setting method,
public get cachedNamespace() {..}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe currentNamespace
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor - could this be a getter/setting method,
public get cachedNamespace() {..}
It looks like it is not allowed to wrap them as a getter/setter methods in the block of
export const Utils = {
// allowed
functionName(): xxx {
xxxxxx
}
// not allowed
set xxxx(xxx: string){
xxxxxxxx
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
currentNamespace
?
I'm ok with either one. will change it to current
.
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
=========================================
Coverage ? 13.13%
=========================================
Files ? 71
Lines ? 25253
Branches ? 0
=========================================
Hits ? 3318
Misses ? 21498
Partials ? 437 Continue to review full report at Codecov.
|
Closes #2439
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.