test: Maybe fix TestPendingRetryWorkflowWithRetryStrategy. Fixes #2446 #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Mar 16, 2020
| @@ -62,7 +62,6 @@ const ( | |||
| // LabelKeyWorkflowTemplate is a label applied to Workflows that are submitted from Workflowtemplate | |||
| LabelKeyWorkflowTemplate = workflow.WorkflowFullName + "/workflow-template" | |||
|
|
|||
|
|
|||
alexec
commented
Mar 16, 2020
| @@ -227,12 +227,10 @@ spec: | |||
| b := wf.Status.Nodes.FindByDisplayName("b") | |||
| return wfv1.NodeSucceeded == a.Phase && wfv1.NodeSucceeded == b.Phase | |||
| }, "pods succeeded", 20*time.Second) | |||
| s.TearDownSuite() | |||
There was a problem hiding this comment.
I think this is the problem
|
PLEASE DON'T WAIT FOR ME TO MERGE THIS ONE! |
simster7
approved these changes
Mar 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #2456 +/- ##
=========================================
Coverage ? 11.69%
=========================================
Files ? 72
Lines ? 28892
Branches ? 0
=========================================
Hits ? 3378
Misses ? 25070
Partials ? 444Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".