Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duration must be a string. Make it a string. #2467

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

foobarbecue
Copy link
Contributor

@foobarbecue foobarbecue commented Mar 17, 2020

Missed this when I fixed the docs here: 96af36d

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@foobarbecue foobarbecue changed the title fix: Duration must be a string fix: Duration must be a string. Make it a string. Mar 17, 2020
@foobarbecue
Copy link
Contributor Author

Actually, wait, don't merge yet -- this happens a few more times in the examples, I'll fix them all.

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@47bc6f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2467   +/-   ##
=========================================
  Coverage          ?   11.23%           
=========================================
  Files             ?       73           
  Lines             ?    30852           
  Branches          ?        0           
=========================================
  Hits              ?     3465           
  Misses            ?    26920           
  Partials          ?      467

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bc6f3...245da88. Read the comment docs.

@foobarbecue
Copy link
Contributor Author

Ok, I think this is ready to go. I looked through examples and docs for retryStrategy: duration and just found one more instance of the problem.

@simster7 simster7 merged commit a59428e into argoproj:master Mar 18, 2020
@foobarbecue foobarbecue deleted the patch-3 branch March 18, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants