-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for IRSA and aws default provider chain. #2468
Conversation
This allow you to set s3 configuration useIRSA: true to tell the exec image to pull configuration from IRSA environment variable.
This will depend on argoproj/pkg#13 |
I've merged the related PR to move you forward. |
Codecov Report
@@ Coverage Diff @@
## master #2468 +/- ##
=========================================
Coverage ? 11.23%
=========================================
Files ? 73
Lines ? 30852
Branches ? 0
=========================================
Hits ? 3465
Misses ? 26920
Partials ? 467
Continue to review full report at Codecov.
|
@alexec I think this looks good now, let me know if there is something I missed? |
This allow you to set s3 configuration useSDKCreds: true to tell the
exec image to pull configuration from IRSA environment variables, or any supported aws sdk credentials following the default priority order
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.