Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for IRSA and aws default provider chain. #2468

Merged
merged 7 commits into from
Mar 19, 2020
Merged

feat: Add support for IRSA and aws default provider chain. #2468

merged 7 commits into from
Mar 19, 2020

Conversation

zachaller
Copy link
Contributor

@zachaller zachaller commented Mar 18, 2020

This allow you to set s3 configuration useSDKCreds: true to tell the
exec image to pull configuration from IRSA environment variables, or any supported aws sdk credentials following the default priority order

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

This allow you to set s3 configuration useIRSA: true to tell the
exec image to pull configuration from IRSA environment variable.
@zachaller
Copy link
Contributor Author

This will depend on argoproj/pkg#13

@alexec
Copy link
Contributor

alexec commented Mar 18, 2020

I've merged the related PR to move you forward.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@47bc6f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2468   +/-   ##
=========================================
  Coverage          ?   11.23%           
=========================================
  Files             ?       73           
  Lines             ?    30852           
  Branches          ?        0           
=========================================
  Hits              ?     3465           
  Misses            ?    26920           
  Partials          ?      467
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 6.3% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bc6f3...5d56ba3. Read the comment docs.

@zachaller zachaller changed the title feat: Add support for IRSA feat: Add support for IRSA and default aws SDK credential finding. Mar 19, 2020
@zachaller zachaller changed the title feat: Add support for IRSA and default aws SDK credential finding. feat: Add support for IRSA and aws default provider chain. Mar 19, 2020
@zachaller
Copy link
Contributor Author

@alexec I think this looks good now, let me know if there is something I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants