Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search archived wf by startat. Closes #2436 #2473

Merged
merged 5 commits into from
Mar 19, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Mar 18, 2020

Closes #2436

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

minStartedAt := time.Time{}
maxStartedAt := time.Time{}
selectors := strings.Split(options.FieldSelector, ",")
for _, selector := range selectors {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not use k8s fields.ParseSelector() because it only supports 3 operators: =, == and !=.

@whynowy
Copy link
Member Author

whynowy commented Mar 18, 2020

Argo - Archived Workflows (1)
Argo - Archived Workflows

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@10a0789). Click here to learn what that means.
The diff coverage is 38.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2473   +/-   ##
=========================================
  Coverage          ?   11.25%           
=========================================
  Files             ?       73           
  Lines             ?    30878           
  Branches          ?        0           
=========================================
  Hits              ?     3476           
  Misses            ?    26932           
  Partials          ?      470
Impacted Files Coverage Δ
persist/sqldb/null_workflow_archive.go 0% <0%> (ø)
persist/sqldb/workflow_archive.go 0% <0%> (ø)
server/workflowarchive/archived_workflow_server.go 62.92% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a0789...1a3444b. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Mar 18, 2020

so that date format - it's not international - can you fix that?

@alexec
Copy link
Contributor

alexec commented Mar 18, 2020

e.g. 18 Feb 2020

@whynowy
Copy link
Member Author

whynowy commented Mar 19, 2020

Argo - Archived Workflows (3)

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@whynowy whynowy merged commit 315dc16 into argoproj:master Mar 19, 2020
@whynowy whynowy deleted the time_search branch March 19, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search archive by started at between two dates and times
2 participants