-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search archived wf by startat. Closes #2436 #2473
Conversation
minStartedAt := time.Time{} | ||
maxStartedAt := time.Time{} | ||
selectors := strings.Split(options.FieldSelector, ",") | ||
for _, selector := range selectors { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not use k8s fields.ParseSelector()
because it only supports 3 operators: =
, ==
and !=
.
Codecov Report
@@ Coverage Diff @@
## master #2473 +/- ##
=========================================
Coverage ? 11.25%
=========================================
Files ? 73
Lines ? 30878
Branches ? 0
=========================================
Hits ? 3476
Misses ? 26932
Partials ? 470
Continue to review full report at Codecov.
|
so that date format - it's not international - can you fix that? |
e.g. 18 Feb 2020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Closes #2436
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.