Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParallelSteps child type so replacements happen correctly #2478

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

crenshaw-dev
Copy link
Member

I failed to double-check the ParallelSteps child type in swagger.json and thus caused this: argoproj-labs/argo-client-gen#5

Tested make java in argo-client-gen. Still get a build error, but a different one (I don't think openapi-generator/java knows how to deal with nested lists). I'll open another issue for that one.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@315dc16). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2478   +/-   ##
=========================================
  Coverage          ?   11.25%           
=========================================
  Files             ?       73           
  Lines             ?    30878           
  Branches          ?        0           
=========================================
  Hits              ?     3476           
  Misses            ?    26932           
  Partials          ?      470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315dc16...0339816. Read the comment docs.

@alexec alexec merged commit e1c9f7a into argoproj:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants