Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor fix and refactory #2517

Merged
merged 1 commit into from
Mar 25, 2020
Merged

chore: minor fix and refactory #2517

merged 1 commit into from
Mar 25, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Mar 25, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b1ad163). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2517   +/-   ##
=========================================
  Coverage          ?   11.31%           
=========================================
  Files             ?       75           
  Lines             ?    31705           
  Branches          ?        0           
=========================================
  Hits              ?     3589           
  Misses            ?    27638           
  Partials          ?      478
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 11.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ad163...ea95513. Read the comment docs.

@whynowy whynowy merged commit b277124 into argoproj:master Mar 25, 2020
@whynowy whynowy deleted the gcs_enh branch March 25, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants