Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update docs for useSDKCreds #2518

Merged
merged 2 commits into from
Mar 26, 2020
Merged

chore(docs): Update docs for useSDKCreds #2518

merged 2 commits into from
Mar 26, 2020

Conversation

zachaller
Copy link
Contributor

@zachaller zachaller commented Mar 26, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@alexec
Copy link
Contributor

alexec commented Mar 26, 2020

You may want to update the other example too.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2518 into master will increase coverage by 0.10%.
The diff coverage is 31.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2518      +/-   ##
==========================================
+ Coverage   11.21%   11.31%   +0.10%     
==========================================
  Files          75       75              
  Lines       31691    31705      +14     
==========================================
+ Hits         3555     3589      +34     
+ Misses      27658    27638      -20     
  Partials      478      478              
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 11.45% <ø> (ø)
workflow/validate/validate.go 73.82% <25.00%> (-0.27%) ⬇️
workflow/controller/workflowpod.go 70.74% <100.00%> (+0.07%) ⬆️
workflow/controller/operator.go 60.94% <0.00%> (+0.20%) ⬆️
workflow/controller/dag.go 57.99% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b277124...dda4f30. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants