feat: UI enhancement for Cluster Workflow Template #2525

sarabala1979 · 2020-03-26T16:33:45Z

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". feat: UI enhancement for Cluster Workflow Template #2525
I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
Optional. I've added My organization is added to the USERS.md.
I've signed the CLA and required builds are green.

…Closes argoproj#1963

Co-Authored-By: Simon Behar <simbeh7@gmail.com>

codecov · 2020-04-02T22:57:47Z

Codecov Report

Merging #2525 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2525   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          83       83           
  Lines       32599    32599           
=======================================
  Hits         3642     3642           
  Misses      28458    28458           
  Partials      499      499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0fdbe...fa0fdbe. Read the comment docs.

simster7

Some initial comments on this PR

simster7 · 2020-04-03T15:06:23Z

docs/cluster-workflow-templates.md

@@ -0,0 +1,162 @@
+# Cluster Workflow Templates


Not sure why this needs to be an entire new doc, especially since it's mostly copy/paste from the other doc. Could you please integrate the new information found here to docs/workflow-templates.md?

I initially thought of adding a section in workflow-template.md. But after I saw workflow-template.md which is very focused on explaining workflow-template and also it has a lot of information. It would be better to have it as a separate file and simply focus on one thing cluster-workflow-template. It has a link to workflow-template.md so Users can go to workflow-template information.

Sure, sounds good 🙂

api/openapi-spec/swagger.json

simster7 · 2020-04-03T15:09:35Z

ui/src/app/app.tsx

@@ -27,6 +30,7 @@ const routes: {
 } = {
    [workflowsUrl]: {component: workflows.component},
    [workflowTemplatesUrl]: {component: workflowTemplates.component},
+    [clusterWorkflowTemplatesUrl]: {component: clusterWorkflowTemplates.component},


Should this be under the WorkflowTempaltes tab instead of its own tab? I'm not sure either way. Why do you think it should be its own?

I posted my feedback on slack for UI changes. I had a discussion with @alexmt to have a tab on-page to switch between workflow-template and cluster-workflow-template. It requires a lot of refactoring on UI module. He suggested having a separate page will be a clean way and also it is easy to implement. I do agree with that. I don't want to overload the workflow-template page with multiple options.

Good point. I agree with this.

Good point, agreed.

...rc/app/archived-workflows/components/archived-workflow-filters/archived-workflow-filters.tsx

ui/src/app/archived-workflows/components/archived-workflow-list/archived-workflow-list.tsx

...kflow-templates/components/cluster-workflow-template-list/cluster-workflow-template-list.tsx

ui/src/app/shared/components/resource-submit.tsx

ui/src/app/workflow-templates/components/workflow-template-list/workflow-template-list.tsx

ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx

pkg/apiclient/_.primary.swagger.json

…ents

simster7

Just one more comment regarding the doc. Also make sure to run make lint; the CI is not catching that.

simster7 · 2020-04-03T19:45:22Z

docs/cluster-workflow-templates.md

+
+`WorkflowTemplate` documentation [link](./workflow-template.md)
+
+## Defining `ClusterWorkflowTemplate`


One example here should be enough. Don't want to add too much redundant information

simster7 · 2020-04-03T19:45:40Z

docs/cluster-workflow-templates.md

@@ -0,0 +1,162 @@
+# Cluster Workflow Templates


Sure, sounds good 🙂

simster7 · 2020-04-03T19:45:58Z

ui/src/app/app.tsx

@@ -27,6 +30,7 @@ const routes: {
 } = {
    [workflowsUrl]: {component: workflows.component},
    [workflowTemplatesUrl]: {component: workflowTemplates.component},
+    [clusterWorkflowTemplatesUrl]: {component: clusterWorkflowTemplates.component},


Good point, agreed.

ui/src/app/shared/components/resource-submit.tsx

sarabala1979 · 2020-04-13T23:15:37Z

#2525

simster7 and others added 30 commits January 16, 2020 12:02

feat: Add ability to submit CronWorkflow and WorflowTemplate from CLI. …

44d15f1

…Closes argoproj#1963

goimports

9325f16

Merge

502b1f4

Comments

1112e2c

Merge branch 'master' into submit-cron

0256c4f

Lint:

d28b316

Merge branch 'master' into submit-cron

8865b9d

Remove submitting from Workflow Template

a8ee360

Convert.go and lint

87a2184

Merge branch 'master' into submit-cron

002582a

Update cli_with_server_test.go

64f6403

feat!: Submittable workflow templates. Closes argoproj#2007

86158b5

metav1

d897d44

Merge branch 'master' into submit-cron

cfd7609

merge

56b5aeb

goimports

76e6a13

private

8689ca7

remove nil check

af3bb73

code review changes

5afea26

goimports

ebeeac6

Merge branch 'master' into submit-cron

9cd6b1f

Merge branch 'submit-cron' into submit-tmpl

2783c94

bits

b482906

Merge branch 'master' into submit-tmpl

f183ffa

Merge branch 'master' into submitable-tmpl

260d3ea

First Draft implementation of Submittable WorkflowTemplate

9845c02

Merge branch 'master' into submitable-tmpl

fadae0e

Merge branch 'master' into submitable-tmpl

b47eb26

Merge branch 'master' into submitable-tmpl

5a34bcb

Update pkg/apis/workflow/v1alpha1/workflow_types.go

feace7d

Co-Authored-By: Simon Behar <simbeh7@gmail.com>

sarabala1979 added 10 commits March 31, 2020 11:42

Merge branch 'master' of https://github.com/argoproj/argo

8c62154

Merge branch 'master' of https://github.com/argoproj/argo

1777b3f

Merge branch 'master' of https://github.com/argoproj/argo

655013f

Merge branch 'master' of https://github.com/argoproj/argo

e02a98c

Merge branch 'master' into ui-clusterwft

70d1e26

Updated upload file

b7c750e

merged missing master changes

42f73f4

Update swagger.json

d4c8e4a

merged master changes

8f70d83

updated go mod

8306fb5

sarabala1979 added 2 commits April 2, 2020 17:47

Added doc

e7849a3

Merge branch 'master' of https://github.com/argoproj/argo

f5e3c8f

simster7 suggested changes Apr 3, 2020

View reviewed changes

crenshaw-dev reviewed Apr 3, 2020

View reviewed changes

pkg/apiclient/_.primary.swagger.json Outdated Show resolved Hide resolved

sarabala1979 added 2 commits April 3, 2020 09:11

Merge branch 'master' of https://github.com/argoproj/argo

da26c49

Merge branch 'master' into ui-clusterwft

69a513e

simster7 self-assigned this Apr 3, 2020

sarabala1979 added 3 commits April 3, 2020 10:31

updated missing file from master branch and addressed few review comm…

5fe7627

…ents

Update workflow-node-info.tsx

0a51568

Update cluster-workflow-template-list.tsx

1106335

simster7 reviewed Apr 3, 2020

View reviewed changes

ui/src/app/shared/components/resource-submit.tsx Show resolved Hide resolved

Update cluster-workflow-templates.md

fa0fdbe

simster7 approved these changes Apr 3, 2020

View reviewed changes

sarabala1979 merged commit 59f746e into argoproj:master Apr 4, 2020

simster7 mentioned this pull request Apr 5, 2020

fix: Fixes lint errors #2594

Merged

alexec mentioned this pull request Apr 6, 2020

What shall we back-port to v2.7.1? #2606

Closed

24 tasks

sarabala1979 mentioned this pull request Apr 13, 2020

UI enhancement for cluster scoped workflowtemplate #2480

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: UI enhancement for Cluster Workflow Template #2525

feat: UI enhancement for Cluster Workflow Template #2525

sarabala1979 commented Mar 26, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading

simster7 left a comment

simster7 Apr 3, 2020

sarabala1979 Apr 3, 2020

simster7 Apr 3, 2020

simster7 Apr 3, 2020

sarabala1979 Apr 3, 2020

simster7 Apr 3, 2020

simster7 Apr 3, 2020

simster7 left a comment

simster7 Apr 3, 2020

simster7 Apr 3, 2020

simster7 Apr 3, 2020

sarabala1979 commented Apr 13, 2020


		`WorkflowTemplate` documentation [link](./workflow-template.md)

		## Defining `ClusterWorkflowTemplate`

feat: UI enhancement for Cluster Workflow Template #2525

feat: UI enhancement for Cluster Workflow Template #2525

Conversation

sarabala1979 commented Mar 26, 2020 • edited Loading

codecov bot commented Apr 2, 2020 • edited Loading

Codecov Report

simster7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simster7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarabala1979 commented Apr 13, 2020

sarabala1979 commented Mar 26, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading