Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong assertions #2531

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix: fix wrong assertions #2531

merged 1 commit into from
Mar 27, 2020

Conversation

dtaniwaki
Copy link
Member

@dtaniwaki dtaniwaki commented Mar 27, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.

bug fix

  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

assert.Error doesn't check error messages while assert.EqualError does.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@67fe04b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2531   +/-   ##
=========================================
  Coverage          ?   11.21%           
=========================================
  Files             ?       75           
  Lines             ?    31765           
  Branches          ?        0           
=========================================
  Hits              ?     3564           
  Misses            ?    27721           
  Partials          ?      480

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fe04b...0a1e4c1. Read the comment docs.

@simster7 simster7 merged commit c924133 into argoproj:master Mar 27, 2020
@dtaniwaki dtaniwaki deleted the fix-wrong-assertions branch March 28, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants