Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate CronWorkflow before creation #2532

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

simster7
Copy link
Member

Fixes: #2529

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #2532 into master will decrease coverage by <.01%.
The diff coverage is 61.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
- Coverage   11.21%   11.21%   -0.01%     
==========================================
  Files          75       75              
  Lines       31765    31769       +4     
==========================================
  Hits         3564     3564              
- Misses      27721    27723       +2     
- Partials      480      482       +2
Impacted Files Coverage Δ
server/cronworkflow/cron_workflow_server.go 52.63% <59.09%> (-1.66%) ⬇️
server/workflow/workflow_server.go 35.08% <63.63%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c924133...f29a3df. Read the comment docs.

@simster7 simster7 merged commit 5e1e782 into argoproj:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo cron lint should run before argo cron create
2 participants