Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example of template-level volume declaration. #2542

Merged

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Mar 29, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

This is a feature that my team now makes heavy use of, but we had to read through the workflow_types.go file to realize it was even possible.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@93b6be6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2542   +/-   ##
=========================================
  Coverage          ?   11.14%           
=========================================
  Files             ?       75           
  Lines             ?    31739           
  Branches          ?        0           
=========================================
  Hits              ?     3538           
  Misses            ?    27720           
  Partials          ?      481

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b6be6...92c68d1. Read the comment docs.

@simster7 simster7 merged commit f142f30 into argoproj:master Mar 30, 2020
@simster7
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants