fix: Fix bug in deleting pods. Fixes #2571 #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug was introduced in July 2019. |
alexec
commented
Apr 2, 2020
| @@ -17,7 +17,7 @@ export interface WorkflowListItemProps { | |||
| } | |||
|
|
|||
| function wfDuration(workflow: models.WorkflowStatus, now: moment.Moment) { | |||
| const endTime = workflow.finishedAt ? moment(workflow.finishedAt) : now | |||
There was a problem hiding this comment.
looks like master needed linting :(
alexec
commented
Apr 2, 2020
| @@ -458,7 +458,7 @@ func DeletePod(c kubernetes.Interface, podName, namespace string) error { | |||
| for attempt := 0; attempt < deleteRetries; attempt++ { | |||
| err = c.CoreV1().Pods(namespace).Delete(podName, &metav1.DeleteOptions{}) | |||
| if err == nil || apierr.IsNotFound(err) { | |||
| break | |||
| return nil | |||
There was a problem hiding this comment.
this is what you get when you do not write tests
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
- Coverage 11.21% 11.17% -0.05%
==========================================
Files 75 83 +8
Lines 31838 32598 +760
==========================================
+ Hits 3571 3642 +71
- Misses 27783 28457 +674
- Partials 484 499 +15
Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Apr 2, 2020
24 tasks
alexec
added a commit
that referenced
this pull request
Apr 6, 2020
simster7
pushed a commit
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".