Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): allow specifying a compression level #2575

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

adamglt
Copy link

@adamglt adamglt commented Apr 2, 2020

Allows setting a compression level for an archive's TarStrategy.
Default falls back to gzip.DefaultCompression, which is the current behavior.

Closes #2574 which contains more info.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2020

CLA assistant check
All committers have signed the CLA.

@adamglt
Copy link
Author

adamglt commented Apr 3, 2020

Seems like a flaky test - rerun?

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Could you add some tests and add this to the appropriate example in examples/?

Also, if you could add this to the docs somewhere that would be great. I know the docs are lacking at the moment, so it might be hard to find a good place to add this. If so, feel free to create a file and I'll add it to the appropriate place during the refactor.

pkg/apis/workflow/v1alpha1/workflow_types.go Outdated Show resolved Hide resolved
workflow/executor/docker/docker.go Outdated Show resolved Hide resolved
@adamglt
Copy link
Author

adamglt commented Apr 3, 2020

Not really sure where to add tests - couldn't find anything testing the exported archive (it seems functional tests run on the examples?).

Added to the archive example and some in the README.md.

@simster7 simster7 self-assigned this Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3d14614). Click here to learn what that means.
The diff coverage is 10.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2575   +/-   ##
=========================================
  Coverage          ?   11.17%           
=========================================
  Files             ?       83           
  Lines             ?    32632           
  Branches          ?        0           
=========================================
  Hits              ?     3647           
  Misses            ?    28487           
  Partials          ?      498
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 10.93% <ø> (ø)
...kg/apis/workflow/v1alpha1/zz_generated.deepcopy.go 0% <0%> (ø)
pkg/apis/workflow/v1alpha1/generated.pb.go 0.46% <0%> (ø)
workflow/executor/executor.go 4.41% <0%> (ø)
util/archive/archive.go 62.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d14614...61b4ab0. Read the comment docs.

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now. Left a suggestion for a test

util/archive/archive_test.go Outdated Show resolved Hide resolved
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, great contribution! Can I encourage you to do more? 🙂

@simster7 simster7 merged commit 79217bc into argoproj:master Apr 3, 2020
@alexec alexec mentioned this pull request Apr 6, 2020
24 tasks
@adamglt
Copy link
Author

adamglt commented Apr 12, 2020

@simster7 is this planned for 2.7.4 or 2.8.x?

@simster7
Copy link
Member

@simster7 is this planned for 2.7.4 or 2.8.x?

This is planned for 2.8 at the end of this month

@simster7
Copy link
Member

@adamglt There should also be a 2.8-rc1 release in a week or so

@simster7
Copy link
Member

@adamglt v2.8.0-rc1 has been released with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting a compression level for archives
3 participants