-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(archive): allow specifying a compression level #2575
Conversation
Seems like a flaky test - rerun? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Could you add some tests and add this to the appropriate example in examples/
?
Also, if you could add this to the docs somewhere that would be great. I know the docs are lacking at the moment, so it might be hard to find a good place to add this. If so, feel free to create a file and I'll add it to the appropriate place during the refactor.
Not really sure where to add tests - couldn't find anything testing the exported archive (it seems functional tests run on the examples?). Added to the archive example and some in the README.md. |
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
=========================================
Coverage ? 11.17%
=========================================
Files ? 83
Lines ? 32632
Branches ? 0
=========================================
Hits ? 3647
Misses ? 28487
Partials ? 498
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better now. Left a suggestion for a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, great contribution! Can I encourage you to do more? 🙂
@simster7 is this planned for |
This is planned for |
@adamglt There should also be a |
@adamglt |
Allows setting a compression level for an archive's TarStrategy.
Default falls back to
gzip.DefaultCompression
, which is the current behavior.Closes #2574 which contains more info.