Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly emit events. Fixes #2626 #2629

Merged
merged 15 commits into from
Apr 10, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 7, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

Changes

  • Correctly emit the events on node completion.
  • Add annotations to event to indicate node type and name.

@alexec alexec linked an issue Apr 7, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2629 into master will increase coverage by 0.07%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2629      +/-   ##
==========================================
+ Coverage   11.23%   11.31%   +0.07%     
==========================================
  Files          83       84       +1     
  Lines       32701    32745      +44     
==========================================
+ Hits         3675     3706      +31     
- Misses      28526    28541      +15     
+ Partials      500      498       -2     
Impacted Files Coverage Δ
util/argo/audit_logger.go 84.61% <94.44%> (ø)
workflow/controller/operator.go 60.83% <100.00%> (-0.21%) ⬇️
workflow/controller/dag.go 50.61% <0.00%> (-4.88%) ⬇️
server/workflow/workflow_server.go 35.21% <0.00%> (-0.63%) ⬇️
workflow/validate/validate.go 74.40% <0.00%> (ø)
pkg/apis/workflow/v1alpha1/workflow_types.go 10.90% <0.00%> (+0.11%) ⬆️
workflow/controller/steps.go 64.89% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7d4bd...58134ba. Read the comment docs.

@alexec alexec requested review from simster7 and sarabala1979 April 7, 2020 21:37
@alexec alexec marked this pull request as ready for review April 7, 2020 21:39
@alexec
Copy link
Contributor Author

alexec commented Apr 7, 2020

Can be merged when green.

@@ -0,0 +1,45 @@
# Workflow Events
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Docs!!

@alexec alexec merged commit 4a3ca93 into argoproj:master Apr 10, 2020
@alexec alexec deleted the fix-2626 branch April 10, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly emit events for node completion
2 participants