Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't attempt to resolve artifacts if task is going to be skipped #2657

Merged
merged 3 commits into from
Apr 10, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Apr 9, 2020

Fixes: #2167

If – once parameter resolution has been done – we determine that the task will not run, do not attempt to resolve artifacts.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2657 into master will increase coverage by 0.06%.
The diff coverage is 32.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
+ Coverage   11.16%   11.22%   +0.06%     
==========================================
  Files          83       83              
  Lines       32675    32696      +21     
==========================================
+ Hits         3648     3671      +23     
+ Misses      28529    28525       -4     
- Partials      498      500       +2     
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 10.78% <0.00%> (-0.12%) ⬇️
server/workflow/workflow_server.go 35.84% <0.00%> (ø)
workflow/controller/operator.go 61.04% <0.00%> (ø)
workflow/controller/dag.go 55.12% <37.50%> (+4.50%) ⬆️
workflow/controller/steps.go 63.38% <45.45%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2caf570...2bc0bd9. Read the comment docs.

@simster7 simster7 merged commit 4c452d5 into argoproj:master Apr 10, 2020
@simster7
Copy link
Member Author

Back-ported to 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact/parameter failure should not be fatal if step/task condition is false
2 participants