fix: Leaf task with continueOn should not fail DAG #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
==========================================
- Coverage 11.62% 11.61% -0.01%
==========================================
Files 84 84
Lines 32871 32822 -49
==========================================
- Hits 3820 3812 -8
+ Misses 28525 28489 -36
+ Partials 526 521 -5
Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Apr 14, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
simster7
added a commit
that referenced
this pull request
Apr 15, 2020
|
Back-ported to 2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case of #2656. If a leaf task has a
continueOnset for its current phase it will still fail the DAG. This PR fixes that.