Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update running-locally.md - corrects protoc install command #2689

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

aistein
Copy link
Contributor

@aistein aistein commented Apr 15, 2020

According to the doc which is currently linked in - one is to install protoc via brew install protobuf, and not via brew install protoc.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

According to the doc which is currently linked in - one is to install protoc via `brew install protobuf`, and not via `brew install protoc`.
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2020

CLA assistant check
All committers have signed the CLA.

@aistein
Copy link
Contributor Author

aistein commented Apr 15, 2020

/review @alexec

@alexec alexec merged commit c1a2fc7 into argoproj:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants