Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix CONTRIBUTING.md and running-locally.md. Fixes #2682 #2699

Merged
merged 2 commits into from
Apr 15, 2020
Merged

docs: Fix CONTRIBUTING.md and running-locally.md. Fixes #2682 #2699

merged 2 commits into from
Apr 15, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 15, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

From #2684

@alexec alexec linked an issue Apr 15, 2020 that may be closed by this pull request
argo/docs/CONTRIBUTING.md has broken link to pull request templage #2682
Closed
@alexec alexec requested a review from simster7 April 15, 2020 16:34
@alexec alexec marked this pull request as ready for review April 15, 2020 16:34
@alexec
Copy link
Contributor Author

alexec commented Apr 15, 2020

This can be merged as soon as green.

@alexec alexec merged commit ee644a3 into argoproj:master Apr 15, 2020
@alexec alexec deleted the docs-3 branch April 15, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argo/docs/CONTRIBUTING.md has broken link to pull request templage
2 participants
@alexec @simster7