Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ui): Fix compression of UI package. #2704

Merged
merged 3 commits into from
Apr 15, 2020
Merged

build(ui): Fix compression of UI package. #2704

merged 3 commits into from
Apr 15, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 15, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review April 15, 2020 20:25
@alexec alexec requested a review from simster7 April 15, 2020 20:25
alexec
alexec commented Apr 15, 2020
View reviewed changes
Makefile
@@ -297,7 +303,7 @@ endif
.PHONY: test
test: server/static/files.go
@mkdir -p test-results
go test -v -coverprofile=coverage.out `go list ./... | grep -v 'test/e2e'` 2>&1 | tee test-results/test.out
go test -v $(TEST_OPTS) `go list ./... | grep -v 'test/e2e'` 2>&1 | tee test-results/test.out
Copy link
Contributor Author

@alexec alexec Apr 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sucked this change in by accident

simster7
simster7 approved these changes Apr 15, 2020
View reviewed changes
Makefile
@@ -381,6 +390,9 @@ start: status install down controller-image cli-image executor-image wait-down u
# Switch to "argo" ns.
kubectl config set-context --current --namespace=argo

.PHONY: run
run: start pf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convenient

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec merged commit 65d413e into argoproj:master Apr 15, 2020
@alexec alexec deleted the build-ui branch April 15, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @simster7