Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove generated Swagger files. #3297

Merged
merged 2 commits into from
Jun 25, 2020
Merged

build: Remove generated Swagger files. #3297

merged 2 commits into from
Jun 25, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 24, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

All the files deleted are just intermediary files on the way to creating swagger.json and we don't really need them bulking up PRs.

@alexec alexec requested a review from simster7 June 24, 2020 23:45
terrytangyuan
terrytangyuan reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks! These are really confusing sometimes.

@alexec alexec marked this pull request as ready for review June 25, 2020 15:48
@alexec alexec merged commit 8e34022 into argoproj:master Jun 25, 2020
@alexec alexec deleted the rm-swags branch June 25, 2020 15:48
alexec added a commit that referenced this pull request Jun 26, 2020
@alexec
build: Remove generated Swagger files. (#3297)
f7e13a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexec @simster7 @terrytangyuan