Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add comment to config map about SSO auth-mode #3634

Merged
merged 2 commits into from
Jul 30, 2020
Merged

docs: Add comment to config map about SSO auth-mode #3634

merged 2 commits into from
Jul 30, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 29, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged. N/A
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This keeps catching people out.

@rbreeze rbreeze self-requested a review July 29, 2020 18:43
rbreeze
rbreeze approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexec alexec marked this pull request as ready for review July 30, 2020 16:12
@alexec alexec merged commit 3f3a4c9 into master Jul 30, 2020
@alexec alexec deleted the alexec-patch-1 branch July 30, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @rbreeze