Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed workflow queue duration if PVC creation is forbidden #3691

Merged
merged 9 commits into from
Aug 6, 2020
Merged

fix: Fixed workflow queue duration if PVC creation is forbidden #3691

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e663374
fix: DAG level Output Artifacts on K8S and Kubelet executor
sarabala1979 Jul 28, 2020
e5d78d4
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 28, 2020
e784e9d
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 29, 2020
a92c98d
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 31, 2020
d6456f6
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 31, 2020
8020986
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 3, 2020
3a21a15
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 4, 2020
81149df
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 6, 2020
b262447
fix: Fixed workflow queue duration if PVC creation is forbidden
sarabala1979 Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workflow/controller/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ func (woc *wfOperationCtx) operate() {
// Error was most likely caused by a lack of resources.
// In this case, Workflow will be in pending state and requeue.
woc.markWorkflowPhase(wfv1.NodePending, false, fmt.Sprintf("Waiting for a PVC to be created. %v", err))
woc.requeue(10)
woc.requeue(10 * time.Second)
return
}
msg := "pvc create error"
Expand Down