Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Emit audit events for workflow event binding errors #3704

Merged
merged 2 commits into from
Aug 13, 2020
Merged

feat(server): Emit audit events for workflow event binding errors #3704

merged 2 commits into from
Aug 13, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 7, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review August 7, 2020 21:33
@alexec alexec assigned sarabala1979 and simster7 and unassigned simster7 Aug 10, 2020
sarabala1979
sarabala1979 approved these changes Aug 13, 2020
View reviewed changes
pkg/apis/workflow/register.go
)

type CRD struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered we need to add new CRD for CRD generation. Do we not need it now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused code

@alexec alexec merged commit ee910b5 into argoproj:master Aug 13, 2020
@alexec alexec deleted the wfeb-ev branch August 13, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexec @sarabala1979 @simster7