Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ingress docs #3713

Merged
merged 2 commits into from
Aug 10, 2020
Merged

fix: Ingress docs #3713

merged 2 commits into from
Aug 10, 2020

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Aug 10, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@groodt groodt changed the title Tiny docs fix. fix: Ingress docs Aug 10, 2020
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simster7 simster7 merged commit 5e5865f into argoproj:master Aug 10, 2020
@omerfsen
Copy link
Contributor

omerfsen commented Oct 16, 2020

There is no need to define LoadBalancer on Svc also it exposes argo-server twice with both Ingress AND LoadBalancer which is a waste of resource so only adding BASE_HREF env variable to deployment AND creating ingress like:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: argowf-server-http-ingress
  namespace: {{argowf_ns}}
  annotations:
    kubernetes.io/ingress.class: "nginx"
    nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
    nginx.ingress.kubernetes.io/backend-protocol: "HTTP"
    nginx.ingress.kubernetes.io/rewrite-target: /$2
spec:
  rules:
  - http:
      paths:
      - backend:
          serviceName: argo-server
          servicePort: 2746
        path: /{{argowf_path}}(/|$)(.*)
    host: {{services_subdomain}}.{{environment_domain}}
  tls:
  - hosts:
    - {{services_subdomain}}.{{environment_domain}}
    secretName: {{argowf_secret}} # do not change, this is provided by Argo Workflow

is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants