feat(executor): Wait for termination using pod watch for PNS and K8SAPI executors. #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 16, 2020
dtaniwaki
reviewed
Oct 19, 2020
Closed
|
|
||
| func UntilTerminated(kubernetesInterface kubernetes.Interface, namespace, podName, containerID string) error { | ||
| log.Infof("Waiting for container %s to be terminated", containerID) | ||
| podInterface := kubernetesInterface.CoreV1().Pods(namespace) |
There was a problem hiding this comment.
I like this idea. It is safer than earlier
sarabala1979
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
LGTM the implementations. @jessesuen Can you quickly look at the security point of view?
This was referenced Oct 26, 2020
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
…PI executors. (argoproj#4253) Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".This PR introduces two improvements:
maincontainer terminated. This allows you to use PNS withrunAsNonRoot, improving its security.